Compare output of JS & Rust versions of /units-for-slot

AmbireTech / adex-supermarket

Rust implementation of the AdEx Supermarket

GNU Affero General Public License v3.0

0 stars 0 forks source link

Closed elpiel closed 3 years ago

elpiel commented 3 years ago

Make sure that the Market and Supermarket implementations of /units-for-slot are aligned and return the same results.

Maybe we could do the following:

Start the Market server (with the AdUnits & AdSlots that will be used)
Setup MockCache with the same and the correct Market server url that was started

TODOs:

Make sure this comparison is repeatable (maybe add steps, commands, gist, etc to this issue)
Seed market and supermarket with the same data
Compare matching with the rules Channels
Compare non-matching with the rules Channels

simzzz commented 3 years ago

I went for the simple ways to just get the output using constant test data. Feedback is appreciated. @elpiel

elpiel commented 3 years ago

LGTM, I've left 2 nitpicks and we might look into making a full README, but it's not a priority for this task.

The question I am more concerned - Do the JS & Rust impls actually align?

elpiel commented 3 years ago

Since the PRs #37 & https://github.com/AdExNetwork/adex-validator-stack-rust/pull/355 this has been checked and any issues were fixed.

I consider this closed