search

AmbireTech / adex-supermarket

Rust implementation of the AdEx Supermarket
GNU Affero General Public License v3.0
0 stars 0 forks source link

Validate the ChannelId when Channel is fetched from the Validator #31

Closed elpiel closed 3 years ago

elpiel commented 3 years ago

This check should be present in: https://github.com/AdExNetwork/adex-supermarket/blob/cc9a80c40b555662b64973efddd57ad8c5ba5bf3/src/cache/api_client.rs#L43-L55

Adapter changes: TODO add issue

The Ethereum Adapter has this validation here:

https://github.com/AdExNetwork/adex-validator-stack-rust/blob/dev/adapter/src/ethereum.rs#L162-L173

elpiel commented 3 years ago

Discussed with Ivo, this isn't required since we are checking the status either way of the Channel and bad status will be returned if the ChannelId is wrong.