AmbireTech / adex-validator-stack-rust

The Ambire AdEx Validator Stack implemented in Rust: sentry, validator worker, adapter, adview manager
https://adex.network
GNU Affero General Public License v3.0
11 stars 10 forks source link

Identifier domain struct/trait #36

Closed elpiel closed 5 years ago

elpiel commented 5 years ago

For the Channel.creator, validator.addr we need a struct/trait implementation that can hold variable-length byte array or a hex string.

We can probably use a variable-length byte array as we already do this for ChannelId and to make it consistent.

https://github.com/AdExNetwork/adex-validator-stack-rust/issues/27#issuecomment-496466022

this format is an ethereum address, but should be represented as an arbitrary variable-length byte array because of flexibility; or a hex string`

elpiel commented 5 years ago

https://github.com/AdExNetwork/adex-validator-stack-rust/pull/38#issuecomment-496908377

As discussed we will not over engineer it and will stick with just Strings