search

AmbireTech / adex-validator-stack-rust

The Ambire AdEx Validator Stack implemented in Rust: sentry, validator worker, adapter, adview manager
https://adex.network
GNU Affero General Public License v3.0
11 stars 10 forks source link

domain crate should not depend on futures #44

Closed Ivshti closed 5 years ago

Ivshti commented 5 years ago

traits that do depend on futures should remain in the sentry crate

there's no reason for these traits to be exported IMO

but more importantly, when they are, you can't use the domain crate without enabling experimental f(ea|u)tures

elpiel commented 5 years ago

Implemented repositories feature for the domain crate in https://github.com/AdExNetwork/adex-validator-stack-rust/pull/50 As we discussed, we will use those Repositories in the Validator as well and implement the REST Api calls repositories in there, again using the domain traits and this feature.