AmbireTech / adex-validator

AdEx validator stack reference implementation: sentry, validator worker
https://www.adex.network
GNU Affero General Public License v3.0
8 stars 11 forks source link

Ethereal Hackathon Bounty: AdEx: build a CLI to manage AdEx channels #3

Closed Ivshti closed 5 years ago

Ivshti commented 5 years ago

Challenge description:

Submission requirements:

Submission deadline:

Judging criteria:

Judging date:

Bounty:

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 1000.0 DAI (1000.0 USD @ $1.0/DAI) attached to it as part of the AdExNetwork fund.

rmshea commented 5 years ago

feel free to use this discord channel to discuss! https://discord.gg/8xtNKWC

mul1sh commented 5 years ago

@Ivshti by any chance is this bounty still open? Thanks 🙂

Ivshti commented 5 years ago

@mul1sh it's no longer part of the hackathon, but yes, the bounty is still open for another 25 days: https://gitcoin.co/issue/AdExNetwork/adex-validator-stack-js/3/2826

mul1sh commented 5 years ago

@Ivshti no worries if its no longer part of the hackathon, I will apply to solve it as a normal bounty then, thanks.

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Cancelled


Work has been started.

These users each claimed they can complete the work by 1 week, 6 days ago. Please review their action plans below:

1) uivlis has started work.

Starting to build the CLI now.

Learn more on the Gitcoin Issue Details page.

uivlis commented 5 years ago

Hey @Ivshti, pinged you up on Discord, was waiting for your response.

uivlis commented 5 years ago

Right, I'll be putting up a repo sometime later today. In the meantime, see my last message on Discord.

Ivshti commented 5 years ago

hey, I can't find the message you're referring to - can you be more specific?

On Wed, 5 Jun 2019 at 07:14, Vlad Silviu Farcas notifications@github.com wrote:

Right, I'll be putting up a repo somewhere later today. In the meantime, see my last message on Discord.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/AdExNetwork/adex-validator/issues/3?email_source=notifications&email_token=AAJQTDJSZRMCN6INLQPMG4DPY44T5A5CNFSM4GF7W4J2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODW6RTAI#issuecomment-498932097, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJQTDKNQFWLDWY7JP2IOG3PY44T5ANCNFSM4GF7W4JQ .

--

[image: photo] Ivo Georgiev Founder & CEO, Stremio

https://www.stremio.com http://www.stremio.com

GPG: AC692BE9EB6E024B5C58A8EAC1E94996BC56BACE http://www.stremio.com http://www.facebook.com/stremio/ http://twitter.com/stremio http://www.instagram.com/stremioofficial/ http://www.reddit.com/r/Stremio/ http://blog.stremio.com/

https://play.google.com/store/apps/details?id=com.stremio.beta https://itunes.apple.com/us/app/stremio/id987232010?mt=8

uivlis commented 5 years ago

Sure, it's the last message on the adex channel on the Gitcoin Events Discord in the Sponsors area. Here, take a look: https://discordapp.com/channels/562828676480237578/567719953457741871

uivlis commented 5 years ago

Right, so currently I am working on submitting the Tx with Identity's execute() (for the open command, for now). Here is the promised repo: https://github.com/uivlis/adexcli

aahutsal commented 5 years ago

@Ivshti is it still actual? @uivlis r u going to complete it?

uivlis commented 5 years ago

Yes, I am working on it. I was waiting for @Ivshti to reply (again) to one of my Discord messages.

On Mon, Jun 10, 2019, 14:17 Arsen A. Gutsal notifications@github.com wrote:

@Ivshti https://github.com/Ivshti is it still actual? @uivlis https://github.com/uivlis r u going to complete it?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/AdExNetwork/adex-validator/issues/3?email_source=notifications&email_token=ABYSGDZX7HIUYWNBO3VPU5TPZYZ4BA5CNFSM4GF7W4J2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXJTN6I#issuecomment-500381433, or mute the thread https://github.com/notifications/unsubscribe-auth/ABYSGD6E2U5PLADY6DBVRM3PZYZ4BANCNFSM4GF7W4JQ .

aahutsal commented 5 years ago

@uivlis ic. good luck with finishing CLI ;)

aerophile commented 5 years ago

Is this challenge still live ?

Ivshti commented 5 years ago

it is, but I don't recommend anyone new starting work on this, since they will be significantly behind

On Sat, 15 Jun 2019 at 18:30, shubham Gupta notifications@github.com wrote:

Is this challenge still live ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/AdExNetwork/adex-validator/issues/3?email_source=notifications&email_token=AAJQTDKDKY3NYXAWHTIO7X3P2UDK7A5CNFSM4GF7W4J2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXY2MSQ#issuecomment-502376010, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJQTDOXRMG26JZIR2VWH33P2UDK7ANCNFSM4GF7W4JQ .

--

[image: photo] Ivo Georgiev Founder & CEO, Stremio

https://www.stremio.com http://www.stremio.com

GPG: AC692BE9EB6E024B5C58A8EAC1E94996BC56BACE http://www.stremio.com http://www.facebook.com/stremio/ http://twitter.com/stremio http://www.instagram.com/stremioofficial/ http://www.reddit.com/r/Stremio/ http://blog.stremio.com/

https://play.google.com/store/apps/details?id=com.stremio.beta https://itunes.apple.com/us/app/stremio/id987232010?mt=8

uivlis commented 5 years ago

Hey, @Ivshti, was wondering whether you also had some examples with logging with an Identity and executing with execute()? I was waiting for your answer on Discord for some days now...

uivlis commented 5 years ago

Jee, the Discord channel was deleted! Anyway, my problem was that I cannot know if the user of the CLI already has an Identity with privileges set for his address since Identities are stored in the browser memory. That's what I was referring by "logging" into an Identity, and not deploying a new one, as you exemplified. What happens, for example, if there are two Identities that have whitelisted the same address? I guess nothing, but I wanted not to duplicate a user's Identity via the CLI. But, if that's ok, I'll do just that.

Ivshti commented 5 years ago

ah, got it; there are APIs on our internal relayer to check if there's an identity for an address, but you shouldn't use that, cause (1) its an internal API and (2) it only tracks identities which are created through the relayer

anyway, for the CLI, for now, you should always create a new identity on the first run and then store it for usage later; but allow an --identity flag that will allow using an existing identity that was previously created

On Sat, 22 Jun 2019 at 12:45, Vlad Silviu Farcas notifications@github.com wrote:

Jee, the Discord channel was deleted! Anyway, my problem was that I cannot know if the user of the CLI already has an Identity with privileges set for his address since Identities are stored in the browser memory. That's what I was referring by "logging" into an Identity, and not deploying a new one, as you exemplified. What happens, for example, if there are two Identities that have whitelisted the same address? I guess nothing, but I wanted not to duplicate a user's Identity via the CLI. But, if that's ok, I'll do just that.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/AdExNetwork/adex-validator/issues/3?email_source=notifications&email_token=AAJQTDJ63RUES4BO7KVWQQ3P3XYFLA5CNFSM4GF7W4J2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYKFS3Y#issuecomment-504650095, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJQTDJZE74S6DQFGXC5U73P3XYFLANCNFSM4GF7W4JQ .

--

[image: photo] Ivo Georgiev Founder & CEO, Stremio

https://www.stremio.com http://www.stremio.com

GPG: AC692BE9EB6E024B5C58A8EAC1E94996BC56BACE http://www.stremio.com http://www.facebook.com/stremio/ http://twitter.com/stremio http://www.instagram.com/stremioofficial/ http://www.reddit.com/r/Stremio/ http://blog.stremio.com/

https://play.google.com/store/apps/details?id=com.stremio.beta https://itunes.apple.com/us/app/stremio/id987232010?mt=8

uivlis commented 5 years ago

Hey, I think the open command is done, look here.

I'm not sure however how to test it out, do I need AdEx tokens (for the validators)?

Ivshti commented 5 years ago

the token doesn't have anything to do with it, campaigns are open with DAI and you can use the default validators, https://tom.adex.network and https://jerry.adex.network

On Sun, 7 Jul 2019 at 13:24, Vlad Silviu Farcas notifications@github.com wrote:

Hey, I think the open command is done, look here https://github.com/uivlis/adexcli.

I'm not sure however how to test it out, do I need AdEx tokens (for the validators)?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/AdExNetwork/adex-validator/issues/3?email_source=notifications&email_token=AAJQTDMYXAFZLEUM5ATFOITP6G77FA5CNFSM4GF7W4J2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZLIWXY#issuecomment-508988255, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJQTDLWG5ZKIA2RECCOLILP6G77FANCNFSM4GF7W4JQ .

--

[image: photo] Ivo Georgiev Founder & CEO, Stremio

https://www.stremio.com http://www.stremio.com

GPG: AC692BE9EB6E024B5C58A8EAC1E94996BC56BACE http://www.stremio.com http://www.facebook.com/stremio/ http://twitter.com/stremio http://www.instagram.com/stremioofficial/ http://www.reddit.com/r/Stremio/ http://blog.stremio.com/

https://play.google.com/store/apps/details?id=com.stremio.beta https://itunes.apple.com/us/app/stremio/id987232010?mt=8

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Cancelled


The funding of 1000.0 DAI (1000.0 USD @ $1.0/DAI) attached to this issue has been cancelled by the bounty submitter

Ivshti commented 5 years ago

no longer relevant