search

AmboVent-1690-108 / AmboVent

AmboVent 1690.108
The Unlicense
205 stars 69 forks source link

Add clang format to clean up code #39

Closed ElectricRCAircraftGuy closed 4 years ago

ElectricRCAircraftGuy commented 4 years ago

Added clang-format to auto-format the code, and ran it on the main Arduino .ino file.

To run the formatter, simply do this from the command line (see main README for both Windows and Linux installation instructions):

./run_clang-format.sh

This should be done before all PRs are merged forever and onward into the future, as a standard practice by the person making the PR before we will merge the PR.

Fixes #21

ElectricRCAircraftGuy commented 4 years ago

After merging this PR, I could use some help from you getting clang-format running on your Windows machine so you can document the process in the main readme. I've written it up already but am not on a Windows machine to test, so I did some guessing and online searching a bit.

By the way, using github to review code can be challenging. I highly recommend using meld instead as a git difftool to view changes from one branch to another. It's an incredible file comparison tool for Windows or Linux. See how to set it up here: https://stackoverflow.com/questions/14821358/git-mergetool-with-meld-on-windows/48979939#48979939 @giorakor @nimrod46

nimrod46 commented 4 years ago

Yep windows version works with that installation instruction, you can update the readme, I approved the PR