Open labeneator opened 4 years ago
Fixes #25. Should also reference #40
@labeneator , this looks pretty useful. Thanks. I'd like to dig into this when I get the chance. Have you done this before or did you just learn how to do it?
Just figured it out in a couple of hours :)
On Mon, 20 Apr 2020, 11:52 Gabriel Staples, notifications@github.com wrote:
@labeneator https://github.com/labeneator , this looks pretty useful. Thanks. I'd like to dig into this when I get the chance. Have you done this before or did you just learn how to do it?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/AmboVent-1690-108/AmboVent/pull/42#issuecomment-616406915, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFU37DFNC3V7FWWIM47FLLRNQENTANCNFSM4MIAAMRQ .
@labeneator Nice! Can you post all the links you used to figure it out please? I'll take a closer look at the links and the PR one of these evenings. Also, is there any way to test it before merging it, or must it be merged first to be able to test it?
Sorry for the late response.
The next steps would be to have the code integrated with unit-test libraries for arduino. A quick google leads to these options, that need to be investigated for suitability:
Also, is there any way to test it before merging it, or must it be merged first to be able to test it?
I think the best thing to do is merge it to a different branch for testing on your repo. You will require to setup a travis-ci account for ambovent. Once you are happy with the setup, you can merge back to master
If you create a travis-ci branch on your repo, I can target this PR @ that branch.
A quick example on how to integrate travis build status.