AmboVent-1690-108 / AmboVent

AmboVent 1690.108
The Unlicense
205 stars 69 forks source link

PR: Add support for L298N driver #54

Open RuairiSpain opened 4 years ago

RuairiSpain commented 4 years ago

Description:

Add support for L298N driver boards

Checklist:

Arduino IDE build output:

Date and time I performed this build: YYYYMMDD-HHMMhrs
(git hash ???????) (IDE ?.?.??) (Arduino ? )

Sketch uses 18140 bytes (59%) of program storage space. Maximum is 30720 bytes. Global variables use 1076 bytes (52%) of dynamic memory, leaving 972 bytes for local variables. Maximum is 2048 bytes.

nimrod46 commented 4 years ago

Please re-review your changes, it seems that you fixed some conflicts incorrectly

ElectricRCAircraftGuy commented 4 years ago

@RuairiSpain , I've edited the IDE output to be only the last 2 lines. I'll update the PR temlate shortly to make it more clear that's all we are looking for. Please update the information about the build output to indicate your Arduino IDE version and board you chose, as well as the git hash you built which corresponds to that output.

Arie001 commented 4 years ago

pin 5 sw3 it is a input reset Alarm why are you using it a pwm is it needed yes but change this is a Physical Change and if needed The PWM header has only 3 Pins For This it needs 4 . image

Here Is the Change on My Version IF needed I can Update The Jumper is to Stop SW3 Shorting the Pin To GND (wire link)

I am on a debug version unconnected pins are the result on nightly version of kicad .