Open lewispg228 opened 2 months ago
Hello, hope this message finds you well. Congrats to your first Issue! We will review it as soon as possiable. Feel free to have a look at https://www.amebaiot.com/en/ameba-arduino-summary/ for more information
Please review our suggested fix for this issue on pull request #240 .
Note, we opted for something slightly different than our proposed change above. In the PR we chose to update the board package library variable "dataMode" ahead of sending that to spi_format(). This way the library variable is updated correctly, in case it is accessed/used elsewhere.
Thanks!
This issue is stale because it has been open for 14 days with no activity.
Boards
SparkFun Thing Plus NORAW306
External Hardware
ADXL313 Breakout with the accompanying Arduino Library.
https://www.sparkfun.com/products/17241
https://github.com/sparkfun/SparkFun_ADXL313_Arduino_Library
Hardware Configuration
Nothing else attached.
Version
latest dev (checkout manually)
IDE Name
Arduino IDE 2.3.2
Operating System
Windows 11 Pro Ver 23H2
Auto Flash Mode
Enable
Erase All Flash Memory (4MB)
Disable
Standard Lib
Disable
Upload Speed
921600
Description
The dataMode does not get set correctly when the Arduino library calls beginTransaction.
Sketch
Error/Debug Message
Reproduce remarks
If we adjust "dataMode" to "settings._dataMode" then the mode is set correctly.
https://github.com/ambiot/ambd_arduino/blob/dev/Arduino_package/hardware/libraries/SPI/src/SPI.cpp#L56
ORIGINAL CODE:
SUGESSTED CHANGE:
More discussion about why this is necessary in Arduino Libraries and Board Packages here.
Thanks!
I have checked online documentation, FAQ, GitHub Wiki and existing/closed issues.