search

Amedomary / touchbar-vscode

Support touch bar for macbook
16 stars 6 forks source link

themeToggle doesn't works correctly #9

Open dawalberto opened 3 years ago

dawalberto commented 3 years ago

If you set touchBar.themeToggle to true the buttons Day/Night appears, however I noticed that when you touch any of this buttons the color theme setted always is Visual Studio Dark.

I changed the next settings:

{
  "touchBar.themeToggle": true,
  "touchBar.nightTheme": "Shades of Purple",
  "touchBar.dayTheme": "Ayu Light"
}

Also I noticed that when you hover touchBar.nightTheme and touchBar.dayTheme settings appears the message "Unknown Configuration Setting"

Tested on Apple M1

andrey-kudinov commented 2 years ago

If you set touchBar.themeToggle to true the buttons Day/Night appears, however I noticed that when you touch any of this buttons the color theme setted always is Visual Studio Dark.

I changed the next settings:

{
  "touchBar.themeToggle": true,
  "touchBar.nightTheme": "Shades of Purple",
  "touchBar.dayTheme": "Ayu Light"
}

Also I noticed that when you hover touchBar.nightTheme and touchBar.dayTheme settings appears the message "Unknown Configuration Setting"

Tested on Apple M1

Change the theme settings, then restart VS Code It helped me

https://github.com/Amedomary/touchbar-vscode/blob/8acc97ffe36a8eec187d9e7f84b97d051325919a/src/extension.ts#L17