search

Amegma / Galaxy-Attack

An inspiration of the original Atari Space Invaders game built in pygame :space_invader: :video_game:
MIT License
40 stars 20 forks source link

fix(#20): change boss laser asset #22

Closed KennyRotella closed 2 years ago

KennyRotella commented 2 years ago

add new image into the assets folder and replace links of the boss laser fixes #20.

Mayank0255 commented 2 years ago

@KennyRotella Good job, just one thing that the laser seems to be shooting from the extreme side of the boss ship, can you adjust it such that it shoots from the center?

KennyRotella commented 2 years ago

Sure, I noticed that also for the previous laser, I was about to open an issue for that. Also the mouse would be awesome to hide while moving the spaceship. Should I adjust it with pygame.mouse.set_visible? I do it in this PR or I open a new one?

Mayank0255 commented 2 years ago

Sure, I noticed that also for the previous laser, I was about to open an issue for that. Also the mouse would be awesome to hide while moving the spaceship. Should I adjust it with pygame.mouse.set_visible? I do it in this PR or I open a new one?

Ya you can do that in this one itself it's ok

KennyRotella commented 2 years ago

@Mayank0255 this time the code should be tested, hoping it doesn't have any side-effect.

Mayank0255 commented 2 years ago

@KennyRotella,

I had a request to make that as Hacktoberfest has only one week left, I am planning to do a tweet on twitter at the end of the month congratulating all the contributors and giving them a special mention for there efforts,

To do this I would like you to do the steps below so that it becomes easy for me to document,

  1. Follow me on Mayank0255
  2. Text me on twitter itself so that I have your twitter handles.
  3. In the text mention three things-
    • GitHub Handle Link
    • Name of the project you worked with me

I hope to receive a favorable reply 🎉

KennyRotella commented 2 years ago

Thank you, it was a nice experience, sadly I don't have a Twitter account, you can mention just my nickname if you wish 😉

Mayank0255 commented 2 years ago

Thank you, it was a nice experience, sadly I don't have a Twitter account, you can mention just my nickname if you wish 😉

Sure