search

Amegma / Galaxy-Attack

An inspiration of the original Atari Space Invaders game built in pygame :space_invader: :video_game:
MIT License
40 stars 20 forks source link

fix(#15): game issue + add explosion animation and sounds #25

Closed rusty-electron closed 2 years ago

rusty-electron commented 2 years ago

list of changes

Closes #15

Mayank0255 commented 2 years ago

@rusty-electron Will take a look at it, by the way the images you have added are of real explosion, can you send me an image of any one of them when it comes into action?

As according to me a pixelated explosion or arcady like explosion would've looked better

rusty-electron commented 2 years ago

It does look pixelated in-game so see if you like the aesthetic or else I will try to find some other assets.

Mayank0255 commented 2 years ago

@rusty-electron

Okay, so couple of things,

  1. Great job with the explosion graphics, but it seems a little out of place as the explosion is real and the game is a pixelated game in which an explosion with a more animated kind of look would have been much better, the implementation though is bang on.

  2. Another thing that hit me instantly was when the ship was getting hit, it sounded like a sound of hitting a tin box, what I would've preferred is the sound that many games have when the health is deducted whenever it is hit. Not the sound of how would it sound when the ship would have been hit, the sound of health deduction, the sound is in my head lol I can't seem to explain myself that good about the sound, let me know if you get it or I will try to explain a little more or try to find a similar kind of sound.

Like there's for health up, something like this for health up I guess health boost

You might get the idea that what I am expecting for damage sound

  1. The explosion sound is okish I think, you might wanna try Pixel chipmunk explosion, or something similar but better
rusty-electron commented 2 years ago
  1. ok, I'll look for pixelated assets.
  2. I'll send you some sound samples on discord to get some idea about the sound.
  3. I'll look into it. Do you know sites that offer free sounds other than freesound and itch.io?
Mayank0255 commented 2 years ago
  1. ok, I'll look for pixelated assets.
  2. I'll send you some sound samples on discord to get some idea about the sound.
  3. I'll look into it. Do you know sites that offer free sounds other than freesound and itch.io?

I am not aware of that, though there is a youtube channel gfx sounds I think, they might provide with the links in the description maybe

rusty-electron commented 2 years ago

@Mayank0255 I think it is merge-ready now.