Open Mayank0255 opened 2 years ago
@Mayank0255 I can take a stab at this. I don't think CI can help with first point, that'll have to be taken care by developer. But all the others are easy to do.
But before that I think we should add setup.py
to the project. It'll give us two benefits:
pypi
Flow:
We will have a release
branch. Whenever this branch gets updated, CI will check setup.py
for version tag. If version has not been updated, CI will fail. Otherwise it'll go ahead and build main.exe
and make a release tag on github (adding Changelog from new PRs).
Alternative Flow:
A new github release is created whenever a git tag
is pushed matching release/*
. It will just build main.exe
and use tag
message to fill in release description.
@nkitsaini
Sorry for the late reply, I got busy with work.
Nice idea. I think the second flow is better as in the first flow the problem would be to keep on changing the version in the code itself, which is slightly harder to maintain.
Should I assign it to you then?
@Mayank0255 Makes sense. Yeah, you can assign to me.
The manual method:
resource_path()
util for loading the assets, be it of any type.pyinstaller.exe .\main.spec --onefile --noconsole
main.exe
file will be generated at./dist
directory, which has to be taken and be uploaded manually to the release as a binary.Major.minor.patch