Closed nkitsaini closed 1 year ago
Let me know what you think about removing Scores
class altogether now.
@nkitsaini Can you please update the readme with instructions to setup the project now as there is a sqlite3 integrated?
Another thing that can you test if the build is working fine or not? In the readme there are some commands which are used to make a release which generates an exe file, after that gets generated, you will need to test if the db is working there as well
Hi @Mayank0255
sqlite3 integrated
This does not require any special setup as sqlite3
is in-built library.
test if build is working
pyinstaller
command provided in README had an issue:
C:\Users\vm\workspaces\Galaxy-Attack>pyinstaller.exe .\main.spec --onefile --noconsole
250 INFO: PyInstaller: 5.4.1
250 INFO: Python: 3.10.7
327 INFO: Platform: Windows-10-10.0.18363-SP0
option(s) not allowed:
--onedir/--onefile
--console/--nowindowed/--windowed/--noconsole
makespec options not valid when a .spec file is given
It was not related to these changes and both --onefile
and --noconsole
were redundant here.
--onefile
is not required since make.spec
specifically defines EXE
(which is a single file) file.
--noconsole
is not required because console=False
is passed to EXE
in make.spec
.
I've fixed pyinstaller
command in README for this.
Otherwise everything works as expected.
Changes:
Db
class as an interface to sqlite dbScores
class to useDb
instead of in-memory list (I'm thinking of removing this class altogether, doesn't provide value now)Score
class to be used instead of scoredictionary
for better type-hintsappdata_dir.py
to help with finding the correct directory to put database file inassets.py
Fixes: #29