Closed PaulLerner closed 2 years ago
Describe the bug
When converting a Report to dict, you only keep one metric while iterating over metrics (overwriting the previous metric in each loop) https://github.com/AmenRa/ranx/blob/master/ranx/report.py#L315
metric
metrics
How to fix replace the line above with: d[m1]["win_tie_loss"][m2][metric] = self.win_tie_loss[(m1, m2)][metric] and init d[m1]["win_tie_loss"][m2] = {} at the same place as https://github.com/AmenRa/ranx/blob/master/ranx/report.py#L309 (just above)
d[m1]["win_tie_loss"][m2][metric] = self.win_tie_loss[(m1, m2)][metric]
d[m1]["win_tie_loss"][m2] = {}
Well spotted, thanks!
Fixed in v0.1.14.
v0.1.14
Describe the bug
When converting a Report to dict, you only keep one
metric
while iterating overmetrics
(overwriting the previousmetric
in each loop) https://github.com/AmenRa/ranx/blob/master/ranx/report.py#L315How to fix replace the line above with:
d[m1]["win_tie_loss"][m2][metric] = self.win_tie_loss[(m1, m2)][metric]
and initd[m1]["win_tie_loss"][m2] = {}
at the same place as https://github.com/AmenRa/ranx/blob/master/ranx/report.py#L309 (just above)