search

AmenRa / ranx

⚡️A Blazing-Fast Python Library for Ranking Evaluation, Comparison, and Fusion 🐍
https://amenra.github.io/ranx
MIT License
427 stars 23 forks source link

Add Makefile and move tests using pytrec_eval into a specific test folder #43

Closed diegoceccarelli closed 1 year ago

diegoceccarelli commented 1 year ago

Add a Makefile with targets to simplify development. I would add more checks in future PRs.

Note that pytrec_eval is not listed a dependency at the moment (and it creates problem to me when I try to install behind a vpn because the setup.pytries to access a website). I'm not surepytrec_eval` is MIT compliant in terms of license (see https://github.com/cvangysel/pytrec_eval/issues/44).

Given that is used only for tests I moved the tests using it into a specific folder and ignore it in the test target. Happy to add a target that install pytrec_eval and run the missing tests.

diegoceccarelli commented 1 year ago

Add a Makefile with targets to simplify development. I would add more checks in future PRs.

Note that pytrec_eval is not listed as a dependency at the moment (and it creates a problem to me when I try to install behind a vpn because the setup.py tries to access a website). I'm not sure pytrec_eval is MIT compliant in terms of license (see https://github.com/cvangysel/pytrec_eval/issues/44). Given that is used only for tests I moved the tests using it into a specific folder and ignored it in the test target. Happy to add a target that installs pytrec_eval and runs the missing tests.