search

AmenRa / retriv

A Python Search Engine for Humans 🥸
MIT License
174 stars 20 forks source link

what if I use retriv in a developing environment without any network（such as a docker container） #10

Closed skykiseki closed 1 year ago

skykiseki commented 1 year ago

have a good experience at using retriv ,

but nltk will download some files when users start to use the package, this means that users developing in offline enviroment can't use it at all.

I think let users to define dicts for their own usage is more people-friendly.

AmenRa commented 1 year ago

Hi and thanks for the kind words!

I understand your needs and thank you for let me know about that. I will make the download of additional data triggered when requested the first time instead that on retriv loading. Note that you can already define your stop-words bypassing NLTK, for example.

AmenRa commented 1 year ago

Hi, I addressed the issue in v.0.2.0. Let me know if the changes solved it. Thank you!

skykiseki commented 1 year ago

Hi, I addressed the issue in v.0.2.0. Let me know if the changes solved it. Thank you!

That's great. I'll try it right away and wait for my feedback

skykiseki commented 1 year ago

v0.2.0 is more efficient to users and the above problems have been solved，no problems have been found so far. Nice work!!!!

AmenRa commented 1 year ago

Sounds great! :)

tshu-w commented 3 months ago

I understand your needs and thank you for let me know about that. I will make the download of additional data triggered when requested the first time instead that on retriv loading.

I think we should only try to download in case of a LookupError (nltk.data.find), otherwise, there will still be issues using it offline even if it has already been downloaded.