search

Ameobea / orange3

Orange 3 data mining suite: http://orange.biolab.si
Other
1 stars 0 forks source link

Daily Progress Updates #13

Closed ameo-unito-bot closed 8 years ago

ameo-unito-bot commented 8 years ago

┆Issue is synchronized with this Asana task

Ameobea commented 8 years ago

See https://github.com/Ameobea/orange3/issues/8#issuecomment-232128265 and https://github.com/Ameobea/orange3/issues/8#issuecomment-232129215

I created a WIP RFC PR here: https://github.com/biolab/orange3/pull/1449

Ameobea commented 8 years ago

I spent a considerable amount of time trying to create a code generator for owtable. I ran into big issues due to the fact that the selection criteria aren't something that can be saved or loaded but rather seem to be taken directly from the active window while the widget is active.

In order to get this data manually, I'll have to search through some PyQT components and dig out values that way. I have a much clearer idea of how to make this happen than when I started and I'm certain I'll be able to figure it out tomorrow.

I also made some small changes to the code generator code by switching some for loops out for list comprehensions per the feedback of @PrimozGodec. I will continue to monitor the PR for feedback and possibly implement more suggestions from there.