Ameobea / robintrack

Scrapes the Robinhood API to retrieve + store popularity and price data.
https://robintrack.net
MIT License
686 stars 194 forks source link

Add an optional `startIndex` param to the most and least popular endpoints #12

Closed Ameobea closed 6 years ago

Ameobea commented 6 years ago

I want to allow users to page through the popularity table for most and least popular symbols. So, I need an optional startIndex param that can be used to offset the search for either most or least popular.

In addition, I'd like the symbols to be secondarily sorted alphabetically by their symbols in the case that two or more symbols have the same popularity.

dalexj commented 6 years ago

do you think startIndex or page is better. theres already a limit param

Ameobea commented 6 years ago

I think startIndex since I'd rather not have a hard-coded page size. I mean we could have a pageSize param and do page; I'm fine with that.

dalexj commented 6 years ago

makes sense

dalexj commented 6 years ago

added this as start_index