Editing Session info (times) results in incorrect information and ambiguous status

CritiqalPete commented 3 months ago

Goal:

Coaches need to be able to easily modify session times for accuracy and see these changes reflected in the UI

Issues:

Sometimes after changing either Start or End time, the view continues to show both old values and even though a reminder appears to "Pull Down to Refresh" its just not intuitive and they appear to not be updated
Sometimes the incorrect values are saved/displayed after refresh (I chose 3pm and 5pm) and it appears here as 11am (11:00) and 1pm (13:00)
The UI is not easy to read and understand and Coaches have to make a serous effort to get through it

Improvement Requests:

Show the new values in the UI after editing along with a red (sync/refreshj) button
Show the team name in the dialog that shows the changed values
Improve the UI entirely with options like: [1hr][2hr] and start time [11][12][01][02][03][04][05] or something like that

Acceptance Criteria:

Session Times can be changed within reasonable limits and are displayed accurately in the app as well as stored in the system.

[ ] Time Zone is considered identical between App and System and does not alter the times entered
[ ] Time is displayed in ALL dialogs in the same 12 hour AM/PM format e.g. "4:00 PM"
[ ] The end time is REQUIRED to be greater than the start time
[ ] Duration is shown in the Summary
[ ] Most recent start and end times for that team are provided, by default, when a New Session is created

CritiqalPete commented 3 months ago

@za-zohaib I think the core problem here is the app is performing some operation on the Session data which is sometimes Null. We need to fix this.

CritiqalPete commented 3 months ago

@za-zohaib I tested this in a recent build and I can see that the times I enter are set at the API and reflected in the DB corectly, but they change in the app UI. For example, I set a 3pm-4pm session and confirmed it in Salesforce. But when I refreshed the app the times appear as 8pm-9pm. This can't even be explained as a time zone correction, as I see it, unless it's somehow referencing a GMT system time somewhere, which it should not.

CritiqalPete commented 3 months ago

this is very important to get fixed now

za-zohaib commented 3 months ago

Going to look at it

AmericaSCORESBayArea / AmericaScores-CoachApp