search

American-Soccer-Analysis / itscalledsoccer-r

R package that wraps the ASA API
https://american-soccer-analysis.github.io/itscalledsoccer-r/
Other
6 stars 0 forks source link

[Bug]: split_by_seasons FALSE API input not working #5

Open mattyanselmo opened 2 years ago

mattyanselmo commented 2 years ago

What happened?

The split_by_seasons 'false' option is not working in the API, as can be tested here.

When I try to select "false" from the dropdown menu I get a 500 error. Through the package's get_player_goals_added() function, you can pass "" or NULL or TRUE into this input to get what you expect, respectively, but not "false" or FALSE, or as it turns out, "fart" either.

Version

0.1.1

What version of Python or R are you using?

R 3.6.x

What operating system are you using?

Windows

Relevant log output

No response

tyler-richardett commented 1 year ago

For future me, a reproducible example: https://app.americansocceranalysis.com/api/v1/mls/players/goals-added?minimum_minutes=6000&season_name=2018%2C2019&split_by_seasons=false.

Also, this combination unexpectedly doesn't enforce the minutes filter: https://app.americansocceranalysis.com/api/v1/mls/players/goals-added?minimum_minutes=6000&season_name=2018%2C2019&split_by_seasons=false&split_by_teams=true&split_by_games=false.