Closed banjtheman closed 1 month ago
Thanks for working on this! It will be a valuable addition to the project.
main
? i find it confusing to have some already merged commits showing as changes alongside the changes you've made. the branch you've submitted against is 4 commits behind main
.python -m src.download_images
the user can include a MAPILLARY
or LOCAL
argument. similarly, for step 3 calculating green view, we may want to let users include an argument defining their preferred analysis method, something like TREEPEDIA
or MASK2FORMER
Agree with Jay, here's how I did something similar for image sources in #42 :
src.gvi
)AbstractBaseClass
) that both the classical GVI method and new segmentation GVI method will inherit from. Something like src/gvi/gvi_scorer.py
, and there should at the very least be a common constructor and a get_gvi_for_image(image_path: Path)
abstract method or similarthis PR addresses #10
it would also be good to save the green score from this segmentation method to a column with a specific header so that the user could run both the "pixel-counting" method and this method on the same files, end up with both result columns, and then compare.
this is superseded by #55
Created a new module to calculate GVI based on the method from the StreetView-NatureVisibility project
README provides steps to install and run locally.