search

AmericanWhitewater / aw-ios

American Whitewater's iOS app
5 stars 2 forks source link

App stuck on Loading River Data during travel #239

Closed AWKevin closed 3 years ago

AWKevin commented 3 years ago

I just drove to PA, opened the app, reset my location (and tried just 15-50 miles) and filtered by distance and nothing I do will get any data to load. It’s been 20 hours and still no rivers…

Gregliest commented 3 years ago

Can you share some more details? We can't debug based on the above. Did you try a region filter to see if reaches are loaded? I assume you checked your connection and that cellular data is enabled for the app?

AWKevin commented 3 years ago

I think the app is getting stuck on a "Region" and that is what caused no rivers to load within 35 or whatever miles from my new location. I think it registered a North Carolina "region" even though I turned that off and filtered solely by distance, so the App could find no rivers within the distance sort and just kept trying. This morning things are different - I am not sure why. The reason I think this is right now I:

  1. Open the app and see rivers within 55 miles of me, but only in PA (I am on the border).
  2. I click on the slide bar icon in the upper right and see a Filter By Region blank screen and off-positioned slider
  3. To be sure I click the slider to turn on Filter By Region and ensure no states are selected.
  4. I unclick the slider, and click on the Distance tab.
  5. My location is correct, distance is correct, and I click done.
  6. I then see a list of rivers - only in PA, even though there are close rivers in MD. I click on Map at the bottom to confirm and see this:

IMG_AE69E0E5E558-1

Gregliest commented 3 years ago

Hmmm, yeah there's definitely a bug here. I just got pins from New England (where I was a few days ago) and Oregon. I think @yeahphil 's work on refactoring the filters should help here. I can't repro anything unfortunately.

AWKevin commented 3 years ago

In case it helps, every time I click on the little slide bar icon at the top to open the filter options it opens on Filter By Region, even though my last filter was by Distance. I think it used to open on whatever filter is currently in use (and maybe still is), which is my expected behavior. Distance and Region need to be exclusive, not overlapping selections, which now seems to be the case. Just some logic to ponder.

Gregliest commented 3 years ago

I think this should be fixed by #243. I'm going to close for now, we can reopen if necessary.

AWKevin commented 3 years ago

This happened again on my trip tot he galley this weekend. States work, distance does not.

yeahphil commented 3 years ago

I think this is caused by #252 -- the app pre-bakes your distance to all the reaches it knows about and has to update that if you move. But that update isn't happening when it's supposed to, so when you filter by distance, you don't get the correct results.

Gregliest commented 3 years ago

Let's try this again and see if it's fixed.