search

AmericanWhitewater / aw-ios

American Whitewater's iOS app
5 stars 2 forks source link

Require iOS 13, more refactoring as a result #247

Closed yeahphil closed 3 years ago

Gregliest commented 3 years ago

What's up with the fantastically enormous diff? I'm not really sure how to review this, maybe we just merge and test.

yeahphil commented 3 years ago

I think the huge diff is all because I moved Apollo from a swiftpm dependency to cocoapods, Pods/ has a checked in copy of the pods, and Apollo is massive.

If you can filter Pods/** out of the diff it should be pretty manageable (can the GitHub web viewer do that?)

yeahphil commented 3 years ago

Stuff up to e9dd3b4 is whatever -- just does what it says and mostly config & env without much code change.

But I'd love to have someone besides me aware of e9dd3b4 in particular, b/c I had to update the way it authenticates GraphQL requests to match the new Apollo way of doing things.

Gregliest commented 3 years ago

Ok I had a look. Not really sure that I'm the best person to check your work, as I haven't used Apollo or GraphQL, and I haven't authenticated anything on iOS in years. But, I'm aware it changed :).

Gregliest commented 3 years ago

@yeahphil My build is failing with this error:

Error: Cannot find module '<>/aw-ios/Pods/Apollo/script
    s/apollo/node_modules/boolean/build/lib/boolean.js'. Please verify that 
    the package.json has a valid "main" entry

Any ideas?