search

AmericanWhitewater / aw-ios

American Whitewater's iOS app
5 stars 2 forks source link

Refresh still broken #265

Open Gregliest opened 3 years ago

Gregliest commented 3 years ago

@yeahphil I've gotten the refresh controller in a couple of bug states.

1) On first run, the last updated time didn't update, and the bar showed the text "Refreshing..." (see photo). I was clicking around and came back to the page after it had finished loading. IMG_7740

2) If you pull to refresh, click on another tab like favorites, and come back to the list, the spinner will be at the top but not spinning. It does seem to go away after a while, which is I assume when the request finishes.

.

yeahphil commented 3 years ago

Lol where is that "Refreshing..." string coming from? I thought we removed it

yeahphil commented 3 years ago

@Gregliest is it possible the TF build didn't have 4e79a1a merged yet? The string "Refreshing..." doesn't appear anywhere in the app source or storyboards any more

Gregliest commented 3 years ago

Haha that's possible, I'll cut a new build once we get these fixes in.

On Thu, Sep 30, 2021 at 4:07 PM Phillip Kast @.***> wrote:

@Gregliest https://github.com/Gregliest is it possible the TF build didn't have 4e79a1a https://github.com/AmericanWhitewater/aw-ios/commit/4e79a1a6e58177723c6e74edc2a27cf6cdd0df1b merged yet? The string "Refreshing..." doesn't appear anywhere in the app source or storyboards any more

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/AmericanWhitewater/aw-ios/issues/265#issuecomment-931763754, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABCI7Z7IGAE3OMFNDIP2LHLUETUSRANCNFSM5FC3GISQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Gregliest commented 3 years ago

We are going to punt on 2) until the next release.