search

AmericanWhitewater / aw-ios

American Whitewater's iOS app
5 stars 2 forks source link

Photos submitting the caption as the subject #272

Open Gregliest opened 2 years ago

Gregliest commented 2 years ago

This line looks like it might be causing this issue. Photo caption is being submitted as the subject.

AWKevin commented 2 years ago

Sure seems like it!

yeahphil commented 2 years ago

Hey just took a look, seems like that would definitely cause the issue.

What should go in that field though? The upload form doesn't have a subject field currently.

865DF76A-B265-4947-A8EA-396BC2B2AA63

AWKevin commented 2 years ago

I can't see the API endpoints so can't tell you. @ryangroth5?

I'd say adding the Subject field to the app would be good.

ryangroth5 commented 2 years ago

Yeah, there are some defaults that get stuffed in there. A blank subject field will null cause it to not pre-populate the subject.

Ryan

On Mon, Nov 29, 2021 at 4:18 PM AWKevin @.***> wrote:

I can't see the API endpoints so can't tell you. @ryangroth5 https://github.com/ryangroth5?

I'd say adding the Subject field to the app would be good.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/AmericanWhitewater/aw-ios/issues/272#issuecomment-982031774, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACOZVFXYQYPYPPQDQZH3HDUOPU2XANCNFSM5IZM3PXQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

ryangroth5 commented 2 years ago

when I say blank I specifically mean "" vs. null or something similar.

Ryan

On Mon, Nov 29, 2021 at 5:12 PM Ryan Groth @.***> wrote:

Yeah, there are some defaults that get stuffed in there. A blank subject field will null cause it to not pre-populate the subject.

Ryan

On Mon, Nov 29, 2021 at 4:18 PM AWKevin @.***> wrote:

I can't see the API endpoints so can't tell you. @ryangroth5 https://github.com/ryangroth5?

I'd say adding the Subject field to the app would be good.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/AmericanWhitewater/aw-ios/issues/272#issuecomment-982031774, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACOZVFXYQYPYPPQDQZH3HDUOPU2XANCNFSM5IZM3PXQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.