search

AmericanWhitewater / wh2o-vue

Interactive map and guide for whitewater rivers in North America
https://wh2o-vue.netlify.app/
9 stars 1 forks source link

Adds Error Interceptor #293

Closed drewalth closed 3 years ago

drewalth commented 3 years ago

Adds interceptor to better handle errors from the API.

drewalth commented 3 years ago

@ryangroth5 good question. I do not think the forEach actually works as I was originally thinking it would. Maybe the best thing to do is just throw each error individually, no forEach.

ryangroth5 commented 3 years ago

You might want to aggregate the errors (errors.join(' ').toString()) or report the first error and store the errors array in a member of the exception (new CustomException(errors[0],errors))

Make sure your interceptor is used on graphql calls only as well (not other service endpoints).

On Mon, Dec 7, 2020 at 11:13 AM Drew Althage notifications@github.com wrote:

@ryangroth5 https://github.com/ryangroth5 good question. I do not think the forEach actually works as I was originally thinking it would. Maybe the best thing to do is just throw each error individually, no forEach.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/AmericanWhitewater/wh2o-vue/pull/293#issuecomment-740017158, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACOZVCCB57O5UZ2G7MFT33STT5JDANCNFSM4UODHRMQ .