What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
externalizes the integrated spa docker dev build script so that the hostname can be parsed from the .env and HMR set properly when running in docker
adds the two flags to vue.config that allow the dev server to take requests outside of localhost (e.g. other containers, my network-local Mac, etc).
updates the docker-container script to use the new build script
What is the current behavior? (You can also link to an open issue here)
SPA rejects HMR and refresh outside of localhost in integrated mode due to CORS and hostname headers
SPA can not reliably guess a non-localhost name for itself in docker
What is the new behavior (if this is a feature change)?
externalizes the integrated spa docker dev build script so that the hostname can be parsed from the .env and HMR set properly when running in docker
adds the two flags to vue.config that allow the dev server to take requests outside of localhost (e.g. other containers, my network-local Mac, etc).
updates the docker-container script to use the new build script
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
this PR liberalizes the defaults of a development hot patching server to allow other hosts to access it, for most people this will not be a concern since they are behind a firewall, dev servers are ephemeral, and CORS and hostname checks can be spoofed by a malicious actor anyway.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
externalizes the integrated spa docker dev build script so that the hostname can be parsed from the .env and HMR set properly when running in docker
adds the two flags to vue.config that allow the dev server to take requests outside of localhost (e.g. other containers, my network-local Mac, etc).
updates the docker-container script to use the new build script
What is the current behavior? (You can also link to an open issue here)
SPA rejects HMR and refresh outside of localhost in integrated mode due to CORS and hostname headers
SPA can not reliably guess a non-localhost name for itself in docker
What is the new behavior (if this is a feature change)?
externalizes the integrated spa docker dev build script so that the hostname can be parsed from the .env and HMR set properly when running in docker
adds the two flags to vue.config that allow the dev server to take requests outside of localhost (e.g. other containers, my network-local Mac, etc).
updates the docker-container script to use the new build script
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
this PR liberalizes the defaults of a development hot patching server to allow other hosts to access it, for most people this will not be a concern since they are behind a firewall, dev servers are ephemeral, and CORS and hostname checks can be spoofed by a malicious actor anyway.
Other information: