search

AmericanWhitewater / wh2o-vue

Interactive map and guide for whitewater rivers in North America
https://wh2o-vue.netlify.app/
9 stars 1 forks source link

first pass at fixing gauge range display #451

Closed ngottlieb closed 2 years ago

ngottlieb commented 2 years ago

I am really not sure about this, the "range" definition stuff is extremely confusing -- as far as I can tell, there are clearly defined options for users defining ranges, but those options include duplicates:

image

I changed the front-end code to reflect the ranges that users are allowed to define today. I guess it's possible that misses ranges users were historically able to define, I have no idea. @ryangroth5

I've tested this on a bunch of reaches and it seems to both a) work and b) resolve @AWKevin's issues (i.e. make this feature work)...but again, I do not feel like I have a real understanding of how this range stuff works, so maybe I'm missing something.

Addresses Need Color Depiction of "Low Runnable" and "High Runnable" Flow Ranges

AWKevin commented 2 years ago

Two things.

1) Thanks for hopefully fixing the FE to show the ranges! 2) As the leaders in recreational flow studies nationwide, we need to refactor these ranges to mirror the methodology that we use for flow studies and to have fewer, more standardized categories. This is a future effort I assume.

ryangroth5 commented 2 years ago

So...it looks like you just considering the minimums or did I get that wrong.

ngottlieb commented 2 years ago

It looks at the minimums first because that uniquely matched almost all the paired options from the form. In the cases where there is ambiguity it checks the maximum as well

On Thu, Jun 23, 2022 at 4:42 PM Ryan Groth @.***> wrote:

So...it looks like you just considering the minimums or did I get that wrong.

— Reply to this email directly, view it on GitHub https://github.com/AmericanWhitewater/wh2o-vue/pull/451#issuecomment-1165015850, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJKLL3QIRREPTN4VXHR6ODVQTY5DANCNFSM5ZSRVU5Q . You are receiving this because you authored the thread.Message ID: @.***>

-- -- Nick Gottlieb Sacred Headwaters: a newsletter about the interconnectedness of social and ecological crises https://sacredheadwaters.substack.com/

ryangroth5 commented 2 years ago

I guess I am going to pull it and try it.

ngottlieb commented 2 years ago

@AWKevin I'm merging this so you can test it. I believe it accurately displays defined ranges (but definitely test it in a number of different situations). It does not do what you asked about in Slack -- interpret the situation where only one "runnable" range is defined into three different chunks.

I can definitely augment with that capability if desired; @ryangroth5 reported in Slack that it was not the original behavior on graphs, just on the coloring of the river table summaries.