search

AmericanWhitewater / wh2o-vue

Interactive map and guide for whitewater rivers in North America
https://wh2o-vue.netlify.app/
9 stars 1 forks source link

Bug/GitHub workflows problem #494

Closed ngottlieb closed 1 year ago

ngottlieb commented 1 year ago

should fix https://github.com/AmericanWhitewater/wh2o/issues/2658

ngottlieb commented 1 year ago

@ryangroth5 this brings the vue codebase in line with beta/prod (to use vue 14) and gets the github workflow to start functioning again -- there were a few different issues, the final one being that our committed lockfile still included references to npm.americanwhitewater.org

ryangroth5 commented 1 year ago

on the npm.americanwhitewater.org, last night I cleared it by issuing something like npm config clear repo and then deleting package-lock.json then reissuing npm i. Is the issue more complicated than that?

ngottlieb commented 1 year ago

No, it's not more complicated than that, but the point is that change had to be done and committed to the repo (which I've done here), otherwise a fresh install of our Vue app would try to source the packages defined in our lockfile and be unable because that registry doesn't exist.