search

AmericanWhitewater / wh2o-vue

Interactive map and guide for whitewater rivers in North America
https://wh2o-vue.netlify.app/
9 stars 1 forks source link

ensure Vue deploy script checks out target branch #539

Open ngottlieb opened 1 year ago

ngottlieb commented 1 year ago

Script currently pulls development, but doesn't check it out, meaning that you could potentially run deploy and still be on a different branch. Not a common situation but worth addressing for 100% determinism with releases

ngottlieb commented 11 months ago

this was mostly already done by another task, but I the script wasn't erroring out when git threw errors. It appears that set -e needs to be set in the script itself, not just in the shell session that executes the script. I added it here: https://github.com/AmericanWhitewater/wh2o-vue/pull/564