search

AmericanWhitewater / wh2o-vue

Interactive map and guide for whitewater rivers in North America
https://wh2o-vue.netlify.app/
9 stars 1 forks source link

Rapid Edit Doesn't Always Pull In Rapid Data #71

Closed ngottlieb closed 4 years ago

ngottlieb commented 4 years ago

Try editing any rapid on Big Laurel (https://wh2o-vue.herokuapp.com/#/river-detail/1039).

I think the problem is that it's not set up to gracefully handle if there is no position set, so the component is crashing.

ngottlieb commented 4 years ago

cc: @AWKevin. In fixing this, I actually added a neat additional piece: if a rapid doesn't have a location specified, when you open the edit window, it uses distance to calculate where the point should be (which will then be saved).

ngottlieb commented 4 years ago

@AWKevin Drew just merged my PR so that issue with Big Laurel should be fixed now

AWKevin commented 4 years ago

Slick! That works great.