search

AmericasWater / awash

America's Water AWASH Model
GNU General Public License v3.0
4 stars 6 forks source link

Optimization of reservoir storage #11

Closed LaurelineJ closed 7 years ago

LaurelineJ commented 7 years ago

Two things are missing in the optimization of the reservoirs:

  1. Minimum storage requirement is 0
  2. Evaporation is not taken into account

Changes should be made accordingly to optimization-given.jl

ulall commented 7 years ago

0 is ok for lb of storage -- we can consider that we consider active storage cap only evap we need

On Wed, Aug 3, 2016 at 2:32 PM, LaurelineJ notifications@github.com wrote:

Two things are missing in the optimization of the reservoirs:

  1. Minimum storage requirement is 0
  2. Evaporation is not taken into account

Changes should be made accordingly to optimization-given.jl

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/AmericasWater/awash/issues/11, or mute the thread https://github.com/notifications/unsubscribe-auth/AE3cO4PG2ROUigtjojfp7iqU1MZt9497ks5qcN6sgaJpZM4Jb9LG .

Upmanu Lall Alan & Carol Silberstein Professor of Engineering, Dept. of Earth & Environmental Engineering Dept. of Civil Eng. & Eng. Mechanics Director, Columbia Water Center Senior Research Scientist, International Research Institute for Climate & Society 842F Mudd Columbia University 500 W 120th Street New York, NY 10027

http://www.columbia.edu/~ula2/ http://water.columbia.edu/ http://bigthink.com/users/upmanulall

LaurelineJ commented 7 years ago

Here I am only focusing on the optimization algorithm, not on the data that we use as input.

LaurelineJ commented 7 years ago

I have created a branch evapoptim. I think it is done, at least the constraints matrices seem correct to me, but I have not check the optimization results.

@jrising : What I have done is to add more constraints generation function in Reservoir.jl and used the new ones in optimization-given.jl. Should I have just deleted the old ones ? I'll perform more tests tomorrow and I'll ask you to validate the merging.

jrising commented 7 years ago

Yes, please delete the old ones. The new ones simplify to the old ones when evaporation is 0, right?

Can you also change remove the special initializer in the test_Reservoir_optimization, and use that to check that the simulation and optimization give the same matrix?

LaurelineJ commented 7 years ago

The code needs to be updated so that evaporation rates scale with timesteps length.

LaurelineJ commented 7 years ago

Done in reservoiroptimbranch. Merging requested.