search

AmericasWater / awash

America's Water AWASH Model
GNU General Public License v3.0
4 stars 6 forks source link

Fixes for simulate #72

Closed jrising closed 6 years ago

jrising commented 6 years ago

Here you go.

For your issue 1, I just removed the getdata function from nui.jl. The Mimi built-in method, where one says model[component, name] has improved to the point that it handles all the relevant cases, SFAICT.

For issue 2, I couldn't reproduce the problem. I found a different problem, which is that cached_fallback was looking for the extraction files in a different location than optimize-surface was writing them, but I think you already fixed that on your side. Once I fixed that, everything was fine.

Note that I fixed this by leaving the code writing into the main data folder, rather than cache. It's not crystal clear that it shouldn't, in the case of optimize-surface, because there's no fall-back option currently that would actually run the optimization, if the data wasn't there. In any case, not worth worrying about for now.

jrising commented 6 years ago

Thanks! I made corresponding changes to other cases of isfinite. I merge now!