[Mod compatibility] Dungeons Enhanced 1.3 prevents loot generation of Artifacts while 1.2 works fine.

[Thombias]

Hey there, so i noticed in my WIP modpack that i somehow no longer get artifacts from the mod of the same name generating in any loot chests and barrels, so i checked out all the changelogs of my last updated mods and realised this mod changed something about loot in the newest version. Turns out that the "revised loot tables" in mod version 1.3 unfortunately prevent artifacts from generating in all possible loot containers they can generate in. I have 2 screenshots here from the same modpack but one with mod version 1.2 and one with mod version 1.3 (Notice the seed in the chat is identical)

Mod version 1.2:

Mod version 1.3:

Side note: The whoopee cushion is supposed to always generate in the bonus chest.

Would love to see a fix for this because i don't wanna miss out on the better configurability and fixes from version 1.3 ^.^

[BarionLP]

I think this is not a problem with dungeons enhanced but I can take a look. Can you send me a list of all mods you're using?

[Thombias]

Here's my mod list:

I also did a seperate test with the minimum required mods, so i only have Dungeons Enhanced, Structure Gel API, Artifacts, ExpandAbility and Curios API installed. The issue still persists, see screenshots below. Seed is still the same.

Bonus Chest loot with Dungeons Enhanced 1.2

Bonus Chest loot with Dungeons Enhanced 1.3

And here's the mod list for the minimum mods test

I'm only providing screenshots from the bonus chest because it has a 100% chance of the item generating, regardless of how high or low the chance for artifacts is being set in the config file. I did test all vanilla structures that can potentially generate artifacts. (things like village chests, desert temples, spawner dungeons, etc.) Even when setting the chance of an artifact generating inside a loot chest to 100%, i get absolutely no artifacts generating whatsoever in mod version 1.3, whereas on 1.2 they do generate like they should. Even the underground campsites provided by the Artifacts mod never have artifacts in them while using Dungeons Enhanced 1.3, despite the chance for artifacts being to 100%. Again, going back to mod version 1.2 fixed this.

I really have no idea why this is happening. All i can really do here is reporting this rather unfortunate issue/incompatibility. :(

[BarionLP]

Are you using any data pack?

[Thombias]

Nope, no datapacks or anything. Just the 5 mods seen in the minimum mod list provided above.

[BarionLP]

ok. i reproduced the bug, hope i can find out why this is happen thanks for reporting

[BarionLP]

I fixed the problem for 1.17 and 1.16 I'll release a hotfix after I double checked everything

[Thombias]

Awesome! Thank you so much for putting in the work to fix this! :)