search

AminHP / gym-anytrading

The most simple, flexible, and comprehensive OpenAI Gym trading environment (Approved by OpenAI Gym)
MIT License
2.13k stars 469 forks source link

Question: TODO on price validation #30

Closed jjphung closed 4 years ago

jjphung commented 4 years ago

@AminHP First off, thank you for your amazing work on this. This has been very helpful for my understanding.

This is just a question on the TODO comment located in the stocks_env line 21 link and forex_env line 22 link.

What did you have in mind for "validating the indices"? Thank you.

AminHP commented 4 years ago

Hi @jjphung, Thanks! I'm glad it was helpful :)

Well, I was thinking of some special cases. For example, what should happen if frame_bound contains negative values or frame_bound[0] - window_size is negative?

But eventually, I concluded that it is unworthy to spend time on those exceptions.

jjphung commented 4 years ago

I was thinking the same thing and also came to the same conclusion before posting this question. Just wanted to run this by you if there was something else I missed. Thanks!

Closing this issue.