search

AminHP / gym-anytrading

The most simple, flexible, and comprehensive OpenAI Gym trading environment (Approved by OpenAI Gym)
MIT License
2.1k stars 465 forks source link

Improvement in Position section #6

Closed super-pirata closed 4 years ago

super-pirata commented 4 years ago

The Wikipedia link was pointing to a paragraph instead of the whole page. Short explanation added.

AminHP commented 4 years ago

Hi. Thank you for your contribution. I am kind of busy at this moment, but I reviewed your pull request and the changes you have made were cool. However, there are some small issues, and I will comment on them in a few days.

AminHP commented 4 years ago

Sorry for the delay. The explanation on the trading positions was very clear, I commented the problems. Please fix them. Thanks!

super-pirata commented 4 years ago

Sorry for the delay. The explanation on the trading positions was very clear, I commented the problems. Please fix them. Thanks!

Fixed them! Thanks for the tips