search

AminHP / gym-anytrading

The most simple, flexible, and comprehensive OpenAI Gym trading environment (Approved by OpenAI Gym)
MIT License
2.09k stars 459 forks source link

minor improve in trading.env #60

Closed GXY2017 closed 2 years ago

GXY2017 commented 2 years ago

To be precise, I guess self._current_tick and self._last_trade_tick shall start from self.window_size instead of None.

        # episode
        self._start_tick = self.window_size
        self._end_tick = len(self.prices) - 1
        self._done = None
        self._current_tick = self.window_size  # None
        self._last_trade_tick = self.window_size  # None
GXY2017 commented 2 years ago

My understanding is wrong after running more trials. Close here.