search

AminHP / gym-mtsim

A general-purpose, flexible, and easy-to-use simulator alongside an OpenAI Gym trading environment for MetaTrader 5 trading platform (Approved by OpenAI Gym)
MIT License
412 stars 101 forks source link

Feature Request: update from gym to gymnasium #39

Closed elliottower closed 5 months ago

elliottower commented 1 year ago

Hi, this repository is currently listed in the gymnasium third party environments but we are cleaning the list up to only include maintained gymnasium-compatible repositories.

Would it be possible for it to be upgraded from gym to gymnasium? Gymnasium is the maintained version of openai gym and is compatible with current RL training libraries (rllib and tianshou have already migrated, and stable-baselines3 will soon).

For information about upgrading and compatibility, see migration guide and gym compatibility. The main difference is the API has switched to returning truncated and terminated, rather than done, in order to give more information and mitigate edge case issues.

Alex2782 commented 1 year ago

https://github.com/AminHP/gym-mtsim/pull/40

The render() function is not yet compatible with SB3 + Gymnasium. 'gym-mtsim' is not a classic render environment, I don't know if it will be easy.

AminHP commented 5 months ago

I just merged the PR and made the library compatible with the latest gymnasium. I will release a new version after adding some improvements to the repo. Thanks again @elliottower and @Alex2782 .

elliottower commented 4 months ago

Nice to hear, if you have time to it would be great if you could create a pr updating https://github.com/Farama-Foundation/Gymnasium/blob/main/docs/environments/third_party_environments.md with updated info and such (easier if the creators write the language themselves so I or someone someone else don’t butcher it)