search

Aminadav / node-run-middleware

NodeJS Express module to simulate URL requests, for internal executing REST API's
https://github.com/aminag/node-run-middleware
ISC License
65 stars 22 forks source link

Support res.set/setHeader with a map of headers #22

Closed quantumew closed 6 years ago

quantumew commented 6 years ago

https://expressjs.com/en/api.html#res.set

@Aminadav Let me know when you can get this in!! Thanks!!

quantumew commented 6 years ago

@Aminadav Awesome, thanks for the speedy response. Let me know if it will be a bit before it gets published. Might internally publish my fork to get people by. A lot of devs use this as part of our preview tool. Great tool!

Aminadav commented 6 years ago

Thank you. In a day or two. Thanks for the pull request.

On Fri, Jul 13, 2018, 9:53 PM Andy notifications@github.com wrote:

@Aminadav https://github.com/Aminadav Awesome, thanks for the speedy response. Let me know if it will be a bit before it gets published. Might internally publish my fork to get people by. A lot of devs use this as part of our preview tool. Great tool!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Aminadav/node-run-middleware/pull/22#issuecomment-404921975, or mute the thread https://github.com/notifications/unsubscribe-auth/ADaxPXy_u8V9CqwT8OrMxii-f3lw2vBFks5uGOyYgaJpZM4VOIXG .

quantumew commented 6 years ago

Perfect!

Sent from my iPhone

On Jul 14, 2018, at 13:28, Aminadav Glickshtein notifications@github.com wrote:

Thank you. In a day or two. Thanks for the pull request.

On Fri, Jul 13, 2018, 9:53 PM Andy notifications@github.com wrote:

@Aminadav https://github.com/Aminadav Awesome, thanks for the speedy response. Let me know if it will be a bit before it gets published. Might internally publish my fork to get people by. A lot of devs use this as part of our preview tool. Great tool!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Aminadav/node-run-middleware/pull/22#issuecomment-404921975, or mute the thread https://github.com/notifications/unsubscribe-auth/ADaxPXy_u8V9CqwT8OrMxii-f3lw2vBFks5uGOyYgaJpZM4VOIXG .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

quantumew commented 6 years ago

Sorry to bother, I noticed a new version of run-middleware was released but when I diff'd the changes it looks like they are the same. Just checking in case you intended to release my changes with that release. Thanks again man!!

On Sat, Jul 14, 2018 at 3:18 PM, Andy Gertjejansen < andygertjejansen@gmail.com> wrote:

Perfect!

Sent from my iPhone On Jul 14, 2018, at 13:28, Aminadav Glickshtein notifications@github.com wrote:

Thank you. In a day or two. Thanks for the pull request.

On Fri, Jul 13, 2018, 9:53 PM Andy notifications@github.com wrote:

@Aminadav https://github.com/Aminadav Awesome, thanks for the speedy response. Let me know if it will be a bit before it gets published. Might internally publish my fork to get people by. A lot of devs use this as part of our preview tool. Great tool!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Aminadav/node-run-middleware/pull/22# issuecomment-404921975, or mute the thread https://github.com/notifications/unsubscribe- auth/ADaxPXy_u8V9CqwT8OrMxii-f3lw2vBFks5uGOyYgaJpZM4VOIXG .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Aminadav/node-run-middleware/pull/22#issuecomment-405041410, or mute the thread https://github.com/notifications/unsubscribe-auth/AOPhE7oUrepJe6tcbR0f03JpkELT5x6Oks5uGjhDgaJpZM4VOIXG .

Aminadav commented 6 years ago

Wow, mistake. Now I published again. Please see the version now: https://unpkg.com/run-middleware@0.9.10/index.js

quantumew commented 6 years ago

It happens! Thanks so much!

Sent from my iPhone

On Jul 16, 2018, at 15:08, Aminadav Glickshtein notifications@github.com wrote:

Wow, mistake. Now I published again. Please see the version now: https://unpkg.com/run-middleware@0.9.10/index.js — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.