search

Aminadav / webpage-screenshot

Entire page Screenshot extension for Google Chrome. I'm developing open source extension for Google Chrome. All extension are free for use. Let's make Chrome great again!
https://www.1ce.org
ISC License
499 stars 519 forks source link

Full Screenshot processes the page vertically, but not horizontal scroll. #39

Closed soundornoise closed 6 years ago

soundornoise commented 8 years ago

Some pages layout their content horizontally instead of/as well as vertically. (e.g. Trello) The tool currently only checks for vertical scroll, but not horizontal.

Aminadav commented 8 years ago

Would you like to try fixing it?

soundornoise commented 8 years ago

😄 I could be talked into it. However, saying as I'm not familiar with the internals, chrome extensions or screen capture, a point in the right direction would be appreciated.

Which file(s) am I most likely to need to change? How do I test this? A link to the correct dev pages or a good blog would be help.

Aminadav commented 6 years ago

It should be fixed. Please test the last version.