AmineDerbal / Space-Travelers-Hub

Space Travelers' Hub In this Project, we will be working with the real live data from the SpaceX API. Our task is to build a web application for a company that provides commercial and scientific space travel services. The application will allow users to book rockets and join selected space missions. The Rockets section displays a list of all avail
https://space-traveler-qf9m.onrender.com/
GNU General Public License v3.0
1 stars 1 forks source link

Kanban board for our React group project #55

Open AmineDerbal opened 1 year ago

AmineDerbal commented 1 year ago
levy002 commented 1 year ago

Hello @AmineDerbal & @ngeelani48 , :wave:

I'm Levy, your PR reviewer

Good job so far :+1: There are some issues that you still need to work on to go to the next project but you are almost there!

HIGHLIGHTS

Status: REQUIRED CHANGES ♻️

Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me @levy002 in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

AmineDerbal commented 1 year ago

we already have all columns @levy002 Kanba

TedLivist commented 1 year ago

STATUS: CHANGES REQUIRED ♻️ ♻️

Hi @AmineDerbal and @ngeelani48,

Good job so far! ✔️ Tasks are properly assigned However, there are some issues that you still need to work on to go to the next project but you are almost there!

Required Changes ♻️

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the Issue thread if something is not 100% clear. And please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Issue for re-reviews. You should use the same Issue submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

ridwanediallo commented 1 year ago

STATUS: APPROVED 🟢

Hi @AmineDerbal and @ngeelani48 ,

Congratulations!GIF

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! 🎉

(Highlights) Good Points: :+1:

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.