AmineDerbal / capstone-project-2

This website is an Api-based webapp that get informations about breeds of dogs from this [base Api](https://thedogapi.com/) and display only the 10 first breeds alphabetically display them and allow us to comment and like those breeds using this [involvement Api](https://microverse.notion.site/Involvement-API-869e60b5ad104603aa6db59e08150270)
https://aminederbal.github.io/capstone-project-2/
MIT License
2 stars 1 forks source link

Kanban board for our capstone project #21

Open AmineDerbal opened 1 year ago

AmineDerbal commented 1 year ago
ABDULALI3468 commented 1 year ago

Changes Required 👍

Hi @AmineDerbal ,

Indeed you did an exceptional but still, there is room for changes to complete this project. 💯

To highlight 🎯

  • Link to the GitHub issue that has a link to the GitHub project ✔️
  • Information about the number of people in the group ✔️
  • Descriptive issue. ✔️

Required Changes ♻️

Check the comments below to have a look at the required changes.

All cards need to be assigned to team members. You will have a circle with the user's avatar on each card. Please consider assigning it in accordance with the project requirements.

image

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear, and please remember to tag me in your question so I can receive the notification.

  • This is My GitHub: GitHub followers
  • This is My Linkedin: Linkedin Badge 
  • This is My Twitter: Twitter Badge 

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

AmineDerbal commented 1 year ago
Omar-Muhamad commented 1 year ago

Changes Required ♻️

Hi @AmineDerbal and @QueenterJuma,

Nice job, you are almost there.

cat-driving-serious

(Changes Required) Aspects to improve: ♻️

image

[Optional] suggestions:

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear, and please remember to tag me in your question so I can receive the notification**

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Omar-Muhamad commented 1 year ago

Approved ✔

Hi @AmineDerbal and @QueenterJuma,

Great job, Your project is complete! There is nothing else to say other than... it's time to close this issue and start working on the project :shipit:

GOOD LUCK 🤞

giphy (1)

(Changes Required) Aspects to improve: ♻️

[Optional] suggestions:

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

**Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear, and please remember to tag me in your question so I can receive the notification**

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.