Open AmineDerbal opened 1 year ago
Hi @AmineDerbal and @Caren-Koroeny ,
Great work so far you still have some changes to make for to get to the next stepπ ![image}(https://media.tenor.com/zr9E2WI4EvMAAAAM/almost-there-reach.gif)
β Tasks are added in Kanban board
[ ] You've done great job to make a plan of the project you will be working, but there are some tasks I am not seeing in Kanban board such as :
Prevention of N+1 queries problem
missing food counter and their price
Form that allow new user to add new food
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!πππ
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Hi Team,
Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! π
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!πππ
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.