search

Aminerman / vue-kinesis

Easily create complex interactive animations with Vue.js
https://www.aminerman.com/kinesis/
MIT License
1.47k stars 59 forks source link

Vue3 Compatibility #49

Closed MadeInFck closed 3 years ago

MadeInFck commented 3 years ago

Hi, are you planning to migrate your module to Vue 3?

Aminerman commented 3 years ago

Hello! Yes, it's in the plans. But it's not the top priority now. I'm working on a lot of new features and a new demo and documentation page. If there are compatibility issues though. I might make it a priority. So let me know if you have had issues with it please.

eybarta commented 3 years ago

Hey man, thx for amazing work... trying to import your library into a vue3/vite project, getting this error: Failed to resolve module import "vue-kinesis/dist/vue-kinesis.esm.js". (imported by /src/main.js)

I tried to build your project inside the folder with npm run build:es, but got errors, Do you have any idea how to resolve this?

Thank you

Aminerman commented 3 years ago

I'll try to reproduce it and get back to you with an answer.

Aminerman commented 3 years ago

Hi again, I did manage to reproduce the issue and investigate for a while. My conclusion is that there are indeed few compatibility issues that I'll have to figure out and fix.

Aminerman commented 3 years ago

Hello once again, I've actually managed to make it compatible with Vue3 on a Vite project. I just need to add few tweaks here and there before relasing. So expect a release later today or tomorrow at most. I'll let you know then.

eybarta commented 3 years ago

You rock! that's great news!

thanks for the fast response.

MadeInFck commented 3 years ago

Amazing, thanks for managing that migration so fast. Can't wait it to use it for my next projet!

Aminerman commented 3 years ago

Hello guys, You can now use vue-kinesis in a Vue3 project by doing : npm install vue-kinesis@next It will install the version 2.0.2 So now the branch next is the branch for the Vue3 compatible version. Please let me know if it works for you and if you encounter any other issues :)

I created this CodeSanbox so you can test quickly: https://codesandbox.io/s/silent-haze-emyps

eybarta commented 3 years ago

Works perfectly for me, thank you very much!

Aminerman commented 3 years ago

Perfect :) I updated the README accordingly. I'll close the issue now. If there is anything that doesn't work as expected, you can open another one. Have fun with the library :)