search

AminoJS / Amino.JS

A powerful JavaScript library for interacting with the Amino API :star2:
MIT License
27 stars 5 forks source link

Update package-lock.json #27

Closed akatsukilevi closed 6 years ago

akatsukilevi commented 6 years ago

Change due to security failure(Changed Hoek version from 4.2.0 to 5.0.3)

felixfong227 commented 6 years ago

YAY @akatsukilevi thanks

Note 👇 Details about the vulnerabilitie

moelrobi commented 6 years ago

But this could resolve into a major depenency error when there were major changes that other depenencies aren't prepered for.

felixfong227 commented 6 years ago

Well, if that's the case, we can always not upgraded the dependency that costing problems

akatsukilevi commented 6 years ago

According to the Travis, it's passing, and if the package upgrades is a problem, we can freeze the version here so

moelrobi commented 6 years ago

Please do minor API Testing, (old Login etc.), when nothing breaks will merge. :)

Sent from my iPad

On 30. Apr 2018, at 18:12, Akatsuki Levi notifications@github.com wrote:

According to the Travis, it's passing, and if the package upgrades is a problem, we can freeze the version here so

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub, or mute the thread.

felixfong227 commented 6 years ago

The resolving patch has been moved to the following commit at the other branch 👇 https://github.com/AminoJS/Amino.JS/commit/2424e3cd912f7a47ca85008b578c0b826d5d8958

Thanks @akatsukilevi 😉