search

AminoJS / Amino.JS

A powerful JavaScript library for interacting with the Amino API :star2:
MIT License
27 stars 5 forks source link

3.0.0 Major Update #36

Open moelrobi opened 6 years ago

moelrobi commented 6 years ago

Major Update PR for AminoJS

akatsukilevi commented 5 years ago

Hey, any update for merging 3.0.0 to master?

moelrobi commented 5 years ago

Once all checks are passing and all methods and endpoints have unit testing, then it will merge into Master. (Prob. Today)

moelrobi commented 5 years ago

Hey @akatsukilevi, since i was in the middle of creating tests for the endpoints i stumbbeld upon your getCheckInCommunities Module.

There is this documentation:

/**
 * Loads Favorite Members
 * @param {SecurityString} sid For authenticating with the Narvii-API.
 * @param {String} coms A list of communities to get the check-in status, separated by "&"
 * @param {String} timezone The desired timezone to check(It will affect the user Check-In Functionality)
 * @returns {Object} Object with all the Check In info of the communities specified from the Logged-in User has in an Array.
 */

Couldn't it be easier if the List of communites would be spearated with , and not by &? Why this design choice?

EDIT: Also please keep the Top Documentation clean. I dont think this Module loads favorite Members. >-> xD

akatsukilevi commented 5 years ago

Hey @akatsukilevi, since i was in the middle of creating tests for the endpoints i stumbbeld upon your getCheckInCommunities Module.

There is this documentation:

/**
 * Loads Favorite Members
 * @param {SecurityString} sid For authenticating with the Narvii-API.
 * @param {String} coms A list of communities to get the check-in status, separated by "&"
 * @param {String} timezone The desired timezone to check(It will affect the user Check-In Functionality)
 * @returns {Object} Object with all the Check In info of the communities specified from the Logged-in User has in an Array.
 */

Couldn't it be easier if the List of communites would be spearated with , and not by &? Why this design choice?

EDIT: Also please keep the Top Documentation clean. I dont think this Module loads favorite Members. >-> xD

First sorry for take ages to reply XD Also, it is separated by & instead of , due to the Amino API itself. I can make it be separated by ,, and before send substitute by &, so the API won't fail and the design will get better What do you think?

EDIT: LOL i didn't noticed that there! XD I'm fixing the Top Documentation now

akatsukilevi commented 5 years ago

Hey, how's the situation for this pull request?

akatsukilevi commented 5 years ago

Hey, any update for this merge?