Author undefined in getChat function

[moelrobi]

Describe the bug In amino.getChat() there is a bug that the authors name is not defined

Expected behavior author.name is undefinded, due to backend change.

[felixfong227]

Question @moelrobi I can't even see there is an author.name key inside the return object

[moelrobi]

helpers/sorter.js:

sendMessageSorter: (uid, element) => {

return {

'threadId': uid,

'messageId': element.messageId,

'msg': element.content,

'type': element.type,

'author': {

'uid': element.author.uid,

'name': element.author.name,

'level': element.author.level,

'role': element.author.role

}

};

},

The Backend now needs

element.author.nickname

Sent from my Galaxy S7 using FastHub

[felixfong227]

Fixed the issue at https://github.com/AminoJS/Amino.JS/tree/issue42 😄

[akatsukilevi]

I tested the issue fix, works perfectly

[felixfong227]

@akatsukilevi You mean the branch I pushed or you are referring another branch 😹

[akatsukilevi]

The one you pushed https://github.com/AminoJS/Amino.JS/tree/issue42 (sorry for late reply)

[felixfong227]

Thanks @akatsukilevi , I’m going to close this issue now, if this problem occurred again(which I think it will🤣) we shall reopen this issue or just simply open an other issue ticket

[moelrobi]

It should not.

Felix Fong notifications@github.com schrieb am Do., 18. Okt. 2018, 19:11:

Thanks @akatsukilevi https://github.com/akatsukilevi , I’m going to close this issue now, if this problem occurred again(which I think it will 🤣) we shall reopen this issue or just simply open an other issue ticket

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/AminoJS/Amino.JS/issues/42#issuecomment-431089508, or mute the thread https://github.com/notifications/unsubscribe-auth/AQ0th4Skst8Iyu4Vx4ZYvt21PLUtu_Opks5umLZZgaJpZM4WLKLc .

[akatsukilevi]

You're welcome!

Thanks @akatsukilevi , I’m going to close this issue now, if this problem occurred again(which I think it will) we shall reopen this issue or just simply open an other issue ticket