Missing Pull Request - Githubissues

AminoJS / Amino.JS

A powerful JavaScript library for interacting with the Amino API :star2:

MIT License

27 stars 5 forks source link

Missing Pull Request #46

Closed akatsukilevi closed 5 years ago

akatsukilevi commented 5 years ago

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

[x] Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
[x] Make sure you are making a pull request against the latest dev branch (left side). Also you should start your branch off our latest dev branch.
[x] Check the commit's or even all commits' message styles matches our requested structure.
[x] Check your code additions will fail neither code linting checks nor unit test.

Description

Had forgot to make this pull request. Added some features(Send Audio/Image/Sticker, Check-In, and Developed a small framework to do the Async calls(It execute the request and after it calls two callbacks, one incase of success and other incase of failure), and also did a rework of the README.md(added examples, how to use and other things)

Thank you!

akatsukilevi commented 5 years ago

The Travis CI failed to build because i forgot to remove the check i did for my fork-repo, will be fixing ASAP

felixfong227 commented 5 years ago

🎉 @akatsukilevi This PR is 🔥 🙈

But one more question so far, any reason for creating the AminoAPI. proccessAction method 😂

https://github.com/AminoJS/Amino.JS/blob/2d4a22f464e28a122d30c2f16ba83a367412779e/framework/main.js#L1-L20

Cuz what I had understood so far is this util class turn the library itself into somewhat callback style like

akatsukilevi commented 5 years ago

First of all thanks a lot for the feedback I will be fixing the issues who was found(I was sleepy when i wrote most of the code so XD) And about the AminoAPI. proccessAction method, it is temporary(for now it is just a helper to deal with the async(instead of need create a new async function to deal with the processing), but later on i will be removing this method and make helpers(like a listener for the chat(call a function every time the chat is updated, notify about notifications, and others). I'm planning on move this framework to another repository(probably a new one, not sure yet)

Also, everyone, Merry christmas 🎄and a happy new year 🎉!

felixfong227 commented 5 years ago

Merry Christmas 🎄and a happy new year bro 🎉@akatsukilevi

felixfong227 commented 5 years ago

Hey @moelrobii after you merge the 3.0 nightly build branch into master, there ton of git conglices 😂

We have to solve it some day yeah 🙈

akatsukilevi commented 5 years ago

Hey @moelrobii after you merge the 3.0 nightly build branch into master, there ton of git conglices

We have to solve it some day yeah

I can work to fix it, just need get back to my country to ble able to work on it(Trip to japan!)

moelrobi commented 5 years ago

So i was in the middle of resolving the branch conflicts and saw that you also created a checkin function. Will resolve that asap, since we don't need two i will be choosing to remove one.

akatsukilevi commented 5 years ago

Thank you very much for the merge! Sorry for not having time to fix the things i told, i've got really busy due to the new year party and the trip to japan! I'ill be working for the next update, to add the voice/video call system, and the screening room(if i can sniff enough packages XD)

moelrobi commented 5 years ago

The last ones would be lovely since, I cant, for whatever reason, sniff packages anymore.

May I ask what Android Version are you using for sniffing?