search

AminoJS / Amino.JS

A powerful JavaScript library for interacting with the Amino API :star2:
MIT License
27 stars 5 forks source link

Remove request-promise and request as dependencies #52

Closed moelrobi closed 5 years ago

moelrobi commented 5 years ago

I would like to remove the dependencies "request" and "request-promise", hence they are only used one Time in upload.js. Since Request is not really used and Narviis API is accepting Base64, we can maybe migrate that to isomorphic-fetch. Since @akatsukilevi you are currently our API dumper i want your Opinon on this. :)

akatsukilevi commented 5 years ago

The request and request-promise can be removed. I'm using it on the upload.jsbecause i was lazy to search for the isomorphic-fetchdocumentation and i went to the one i already knew XD I'll be making the changes to be able to remove the dependencies

akatsukilevi commented 5 years ago

The dependency on request and request-promise is not needed anymore. I removed it from the packages.json, and the upload.js now uses the isomorphic-fetch

EDIT: i didn't commited the change yet, because i want to fix the JSON parse error bug together on it